What is the behavior of the try catch statement in lines 1707-1729 in the ui.cpp in the release 0.1?

1

In the first public release, ui.cpp has this code on the lines in the subject:

void CSendingDialog::OnReply3(CDataStream& vRecv)
{
    int nRet;
    try
    {
        vRecv >> nRet;
        if (nRet > 0)
        {
            Error("The payment was sent, but the recipient was 
                unable to verify it.\n"
                "The transaction is recorded and will credit to 
                the recipient if it is valid,\n"
                "but without comment information.");
        return;
        }
    }
    catch (...)
    {
        //// what do we want to do about this?
        Error("Payment was sent, but an invalid response was received");
        return;
}

The try catch statement at the bottom shows the error as payment sent but invalid response was received. In this case, does this mean that the send BTC would be lost forever as in this question or does this mean that the transaction would be part of some orphaned block (like here).

Bonus, was something done to address the comment in the code?

erasmortg

Posted 2018-10-21T12:37:46.177

Reputation: 263

1Bitcoin originally had a "send to IP address" feature where you would connect to an IP address, ask them for a public key, and create a transaction using that public key as output. This code is part of that feature. This mechanism was eventually removed, so that's the eventual answer to "was something done". – Nate Eldredge – 2018-10-21T15:30:24.410

No answers